Only remove explicit bracketed footnote markers. Plain letter-digit text cannot distinguish identifiers from flattened footnotes. Update the old suffix-removal expectation and cover the intentional superscript compatibility change.
Synchronize selected chapter ordinals at update and finish while retaining prepared narration and speakers for unchanged source chapters at the same chunk level. Rebuild only newly selected or changed chapters, and propagate chapter voice overrides.
Add synthetic regression coverage for selection toggles, prepared fields, chunk levels, normalization calls and an opt-in EPUB check.
Fixes#220
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Map the cover after the optional FFmetadata input and omit use_metadata_tags only for cover-bearing exports. Preserve non-empty supplied text values as UTF-8 MP4 freeform tags alongside standard atoms using existing Mutagen.
Add command-line regression cases and real-FFmpeg round trips for artwork, chapters, audio, and custom metadata. The no-cover path is unchanged.
Fixes#221
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Use %s for three Optional[float] diagnostics so the WebUI Rich handler does not turn a valid speed=None into a conversion failure. Preserve request-speed fallback semantics and add focused regression coverage.
Fixes#218
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Opening a large EPUB spent most of its time in two linear scans repeated
once per navigation entry:
- _find_doc_key scanned every spine document for a basename match.
- spine_docs.index() / _docs_between looked up spine positions by list scan.
Build a basename lookup once per doc_order mapping and a
{document: first spine index} map, in both the PyQt parser (book_parser.py)
and the WebUI extractor (text_extractor.py). Exact and URL-decoded matches
are still tried first, and spine positions keep list.index() first-occurrence
semantics.
On a 41 MB EPUB with 7,520 chapters the PyQt parser drops from ~147 s to
~19 s and the WebUI extractor from ~30 s to ~19 s, with byte-identical
extracted text.
Partially addresses #209 (suggestions 1 and 2).
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
An opening quote without a matching closing mark made
_normalize_all_caps_quotes append the remainder twice: the unmatched
branch appends text[index:] and breaks without advancing index, so the
tail block below the loop appends the same remainder again. Because
emit_text normalizes every chunk before synthesis, the duplicate was
spoken aloud and written into the caption cues (issue #196). Sentence
and paragraph chunking routinely produce unclosed marks, so this hit
every quotation spanning multiple sentences.
Consume the remainder before breaking, and add regression tests that
cover the unmatched-remainder cases across quote styles plus a pair
that must still get caps normalization before an unclosed tail.
🤖 Generated with Codebuff
Co-Authored-By: Codebuff <noreply@codebuff.com>
open_audio_sink() ran the merged-output ffmpeg with stderr=DEVNULL and never
checked the return code, so a failed encode silently produced a truncated file
(no moov atom) that then broke the metadata-embed step with a misleading
'exit 254'. This was observed live on a real PDF->M4B job.
Now:
- ffmpeg stderr is written to <out>.ffmpeg.log (diagnosable after the fact).
- a non-zero exit raises RuntimeError with the stderr tail and removes the
truncated output, instead of silently closing.
Regression tests:
- a non-zero ffmpeg exit raises (not silently closes).
- ffmpeg stderr is redirected to a real file handle (not DEVNULL).
Verified: 19/19 tests in tests/test_domain_audio_sink.py pass (Python 3.11).
Also verified end-to-end on the build host: the instrumentation is what surfaced
the real embed-step ffmpeg output (all chapters mapped, moov moved) confirming a
full, chaptered 72.9 MB M4B.
Closes the diagnostic gap from homelab issue #110.
Adds TestApplyM4bChaptersMutagen to tests/test_exporters.py, covering the
method that the #195 fix touches:
- empty chapters -> returns False, logs nothing.
- mutagen installed but no writable chapter API (the expected case) ->
returns False and logs an accurate debug note, NOT the misleading
'mutagen is not installed' warning. This is the #195 regression.
- mutagen genuinely missing -> returns False and keeps the warning
(backward-compatible).
Verified: the full pytest suite passes identically with and without the
fix (1494 -> 1497 passing, the delta is exactly these 3 new tests; the
pre-existing failures are environment-only and unchanged).
Run execute_conversion on a plan from build_conversion_plan and check
that an existing book.wav stays untouched while the new output goes to
book_2.wav, that a third run gets book_3.wav, that project mode checks
its audio subfolder, and that a request without original_filename is
named after the source file. Note both changes in CHANGELOG.md.
resolve_output_layout computed a unique base name via resolve_unique_path
but discarded it, and the executor rebuilt the merged audio path from the
raw base name. Converting the same book twice silently overwrote the
previous audiobook (and its subtitles, which derive from the audio path).
- store the unique path in OutputLayout.merged_path (checked against the
directory the audio is actually written to)
- make resolve_merged_path prefer layout.merged_path
- have the executor use resolve_merged_path instead of its own _base_name
- add a regression test
Fixes#203
fix(subtitles): enhance ellipsis and paragraph break handling in subtitle processing
feat(gui): implement background update check for new versions
test(tests): add tests for ellipsis handling and paragraph breaks preservation
- kokoro_text_normalization:
- refactor _cleanup_spacing to contextually distinguish opening vs closing
straight quotes (" and ') so leading quotes do not have spaces added after
them and spaces before opening quotes are preserved
- recognize non-English opening delimiters (¡, ¿, «, 「, etc.) and closing
delimiters (», 」, etc.) in spacing normalization
- in normalize_apostrophes, reconstruct text using original token offsets
to preserve inter-token whitespace instead of blindly joining with spaces
- subtitle_generation:
- add _is_sentence_boundary to recognize sentence punctuation followed by
closing quotes/brackets (.", !", ?") in regex and karaoke modes
- support proportional splitting for single FakeToken multi-sentence segments
in spaCy mode (Supertonic / non-English Kokoro)
- support newline splitting for Line mode in FakeToken fallbacks
- safely convert language and subtitle_mode inputs
- tests:
- add tests/test_subtitle_scenarios.py covering quotes, dialogues,
paragraphs, contractions, all subtitle modes, and all TTS token styles
Three related fixes:
- make_subtitle_writer: accept word-count modes ("N words") in
create_subtitle_writer. SubtitleMode("5 words") raised ValueError,
which make_subtitle_writer swallowed and returned None, so PyQt never
created or wrote the subtitle file when an "N words" mode was selected.
Unknown modes now fall back to SubtitleMode.SENTENCE (writers only
branch on SENTENCE_HIGHLIGHT). Regression test added.
- gui.py: refresh subtitle combo item availability after initial
voice/profile selection. update_subtitle_options_availability() ran
during initUI with selected_lang=None for a profile, taking the
non-English branch and disabling Highlighting/N-words items; the fix-up
never re-ran because setCurrentIndex on an already-current index emits
no signal. Now called once more after the profile/voice language is
resolved.
- AssWriter: stop discarding per-word karaoke timing. _add_karaoke_tags
unconditionally replaced entry text with uniform {\\k100} tags,
destroying the real per-word {\\kf} timings from
_process_karaoke_highlighting. Only synthesize simplified tags when the
text has no karaoke tags. Regression test added.
Sentence modes processed all text as a whole: Pipeline.__call__ merged every
engine segment back into one (whole text, no per-token timings), producing a
single giant subtitle and whole-text progress logs.
- tts_plugin/types: add TokenTiming, AudioSegment, SynthesizedAudio.segments
- tts_plugin/utils: Pipeline yields one Segment per engine segment (with
tokens); merged fallback only when engine provides none
- kokoro engine: expose per-segment graphemes/audio + per-word token timings
- supertonic engine: expose per-segment graphemes/audio (no tokens)
- split_pattern: English Sentence/Sentence+Comma engine split is newline-only
(boundaries applied at subtitle time via spaCy); non-English Sentence+Comma
with spaCy ON uses spaCy pre-segmentation + newline engine split (no
commas); spaCy-off fallback keeps comma pattern
- tts_segments: restore inter-segment whitespace on real per-word token
boundaries only (never FakeToken fallbacks)
- _to_language_enum: accept Language enum input (str(enum) is "Language.ES",
silently resolved to EN_US and disabled spaCy pre-TTS for every language
in WebUI)
- pyqt/conversion, utils: replace print with logging
- add AGENTS.md documenting the segmentation/subtitle contract for future
sessions
- tests: update English split-pattern expectations (1566 passing)
Complete the Language enum unification (commit 0dc491e) for the PyQt
GUI, which was left resolving languages from kokoro letter codes
(voice[0]) while domain and WebUI already used Language enums.
- selected_lang is now always a Language enum: voices resolve via
language_for_voice_id(), profiles via resolve_profile_language()
- kokoro letter->Language mapping stays in the engine (new public
language_for_code()); the Language.from_code() domain shim is removed
- legacy profile files with letter codes ("a", "e", ...) are tolerated
only at the profile read boundary; new profiles save ISO codes
- conversion.py letter comparisons replaced with enum comparisons, and
SynthParams lang_code= -> language= (would TypeError at runtime)
- subtitle dropdown enabled for all languages; word-count and
highlighting modes restricted to English with auto-switch to Sentence
- tests: engine mapping + profile language resolution added; 1566 pass
- Create domain/text_utils.py with canonical calculate_text_length
(strips chapter markers, voice markers, metadata tags)
- Remove calculate_text_length from utils.py and subtitle_utils.py
- Update all imports to use domain.text_utils directly
- Create application/chapter_selection.py with build_chapter_payload()
(orchestrates preselection + character count + safety net)
- Replace manual chapter logic in form.py with build_chapter_payload()
- 22 new tests for text_utils and chapter_selection (1550 total)
- Add expand_metadata_aliases() for concept fan-out (series→5, author→2,
description→2, tags→3 keys)
- Replace _normalize_metadata_tags in webui/service.py with
normalize_metadata_map from domain
- Replace _normalize_metadata in epub3/exporter.py with
normalize_metadata_map from domain
- Replace manual fan-out in form.py with expand_metadata_aliases()
- Rewrite metadata_overrides.py to use expand_metadata_aliases()
- Remove unused normalize_metadata_casefold import from exporters.py
- 19 new tests for expand_metadata_aliases (1528 total)
Move build_narrator_roster, build_speaker_roster, match_configured_speaker,
apply_speaker_config_to_roster, prepare_speaker_metadata from
webui/routes/utils/voice.py to domain/speaker_metadata.py.
- prepare_speaker_metadata now accepts optional inject_recommended callback
for UI-specific voice enrichment
- 47 new tests in test_domain_speaker_metadata.py
- All 1509 tests pass
- Add formula_from_profile, resolve_profile_voice, resolve_voice_setting, resolve_voice_choice to domain/voice_resolution.py
- Add build_voice_catalog, filter_voice_catalog to domain/voice_catalog.py
- Update webui/routes/utils/voice.py to import from domain
- Update webui/routes/utils/form.py and voices.py to import from domain directly
- Update synthesize.py to use domain resolve_voice
- Add 29 tests for voice resolution functions
- Move stored_integration_config(), build_audiobookshelf_config() to domain/settings_core.py
- Remove legacy fallback from stored_integration_config() (only config[integrations])
- Add load_audiobookshelf_config() as combined entry point
- PostConversionHooks reads config directly via stored_integration_config()
- WebUI imports from domain/settings_core instead of webui/routes/utils/settings
- Remove duplicate _build_abs_config() from PostConversionHooks
- Remove dead audiobookshelf code from infrastructure/exporters.py
- Remove duplicate audiobookshelf functions from webui/service.py
- Fix OutputFormat enum serialization in output_layout_service.py and conversion_executor.py
(f'{enum}' gave 'OutputFormat.WAV' instead of '.wav')
- Mock spaCy in test_returns_at_least_one_segment instead of loading real model
- Add 28 tests for PostConversionHooks and build_audiobookshelf_config
- Deleted _prepare_tts_context() (104 lines of duplicated logic)
- Replaced with direct build_tts_context() call in run_conversion()
- Fixed _finalize() to use raw fields (generate_epub3, epub3_book_id)
- Removed _MockJob antipattern
- Updated tests to use raw normalization_overrides field
- ConversionRequest uses raw fields instead of PronunciationConfig/Epub3ExportConfig
- Added speakers field to ConversionRequest
- Rewrote collect_required_voice_ids(), initialize_voice_cache(),
job_voice_fallback(), chapter_voice_spec(), chunk_voice_spec()
to accept ConversionRequest instead of job
- PipelinePool.get() now takes request= instead of job=
- Updated all tests to use ConversionRequest interface
- 1493 tests passing
- conversion_pipeline.py: new spacy_pre_tts_segmentation() function
- Handles: condition checks, language exclusion, split_pattern override
- Executor: integrated spaCy pre-TTS before each synthesize_text() call
- 6 new tests for condition checks and fallback behavior
- English excluded from pre-TTS (spaCy only for post-TTS subtitles)
- Fallback to regex when spaCy unavailable
- MarkerCollector: SRP extraction from executor (observation, not execution)
- Outro marker: executor now records outro as chapter marker
- Voice format: chapter voices [{provider, voice}], chunk voice {provider, voice}
- _finalize(): build_metadata_payload() + metadata.json + record_override_usage()
- ffmetadata: voices list → comma-separated string
- EPUB3: ChunkOverlay.voice = dict, _render_chunk_inline handles dict format
- 8 new tests: multi-speaker, ffmetadata format, EPUB3 format
- Updated existing tests for new voice format
- Remove 77 unused imports across domain/application/runner files via ruff
- Add # noqa: F401 to re-exports used by tests and debug_tts_runner
- Fix build_tts_context: usage_counter uses 'is not None' instead of truthiness
- Fix test assertions: compiled rules use 'replacement' key not 'pronunciation'
- Add re-exports: _compile_pronunciation_rules, _merge_pronunciation_overrides
- Language enum: en-US, en-GB, es, fr, hi, it, ja, pt-BR, zh
- Engine-specific mappings (kokoro → single-letter) live in pipeline_factory and synthesize
- spacy_utils uses Language enum keys for model mapping
- split_pattern uses Language enum properties (is_cjk)
- Updated all tests to use ISO codes
- SubtitleMode, OutputFormat, SaveMode, SubtitleFormat, InputFormat
- Properties: dot_ext, is_lossless, is_book, is_subtitle
- from_str/from_path class methods with normalization
- Updated domain and application layers to use Enums
- 17 new tests for enum validation and properties