Dymas/abogen
1
0
Fork 0
mirror of https://github.com/denizsafak/abogen.git synced 2026-07-18 13:40:27 +02:00
Code Issues Packages Projects Releases Wiki Activity

Add performance tests and optimize repeated path operations

Browse Source 
Co-authored-by: denizsafak <39929354+denizsafak@users.noreply.github.com>
This commit is contained in:
copilot-swe-agent[bot]
2025-11-20 23:18:11 +00:00
co-authored by denizsafak
parent 5ec06e7d49
commit 4ad384dc9f
2 changed files with 217 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
abogen/conversion.py
+6 -4
View File
@@ -1010,9 +1010,10 @@ class ConversionThread(QThread):
parent_dir, f"{sanitized_base_name}{suffix}_chapters"
)
# Only check for files with allowed extensions (extension without dot, case-insensitive)
# Optimize by splitting path only once per filename
clash = any(
os.path.splitext(fname)[0] == f"{sanitized_base_name}{suffix}"
and os.path.splitext(fname)[1][1:].lower() in allowed_exts
(name_parts := os.path.splitext(fname))[0] == f"{sanitized_base_name}{suffix}"
and name_parts[1][1:].lower() in allowed_exts
for fname in os.listdir(parent_dir)
)
if not os.path.exists(chapters_out_dir_candidate) and not clash:
@@ -1753,9 +1754,10 @@ class ConversionThread(QThread):
allowed_exts = set(SUPPORTED_SOUND_FORMATS + SUPPORTED_SUBTITLE_FORMATS)
while True:
suffix = f"_{counter}" if counter > 1 else ""
# Optimize by splitting path only once per filename
if not any(
os.path.splitext(f)[0] == f"{sanitized_base_name}{suffix}"
and os.path.splitext(f)[1][1:].lower() in allowed_exts
(name_parts := os.path.splitext(f))[0] == f"{sanitized_base_name}{suffix}"
and name_parts[1][1:].lower() in allowed_exts
for f in os.listdir(parent_dir)
):
break