From 5ec06e7d493b2a1d88482fd7e7a2b58e7bc6eb9c Mon Sep 17 00:00:00 2001
From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com>
Date: Thu, 20 Nov 2025 23:13:22 +0000
Subject: [PATCH] Replace busy-wait loop with threading.Event for better
 efficiency

Co-authored-by: denizsafak <39929354+denizsafak@users.noreply.github.com>
---
 abogen/conversion.py | 14 ++++++++------
 1 file changed, 8 insertions(+), 6 deletions(-)

diff --git a/abogen/conversion.py b/abogen/conversion.py
index e05a2db..3ba0d7b 100644
--- a/abogen/conversion.py
+++ b/abogen/conversion.py
@@ -653,6 +653,7 @@ class ConversionThread(QThread):
     ):  # Add use_gpu parameter
         super().__init__()
         self._chapter_options_event = threading.Event()
+        self._timestamp_response_event = threading.Event()
         self.np = np_module
         self.KPipeline = kpipeline_class
         self.file_name = file_name
@@ -872,15 +873,15 @@ class ConversionThread(QThread):
                     self.log_updated.emit("\nDetected timestamps in text file")
                     # Signal to ask user (-1 indicates timestamp detection)
                     self.chapters_detected.emit(-1)
-                    # Wait for user response
-                    while not hasattr(self, "_timestamp_response"):
-                        if self.cancel_requested:
-                            self.conversion_finished.emit("Cancelled", None)
-                            return
-                        time.sleep(0.1)
+                    # Wait for user response using event instead of busy-wait loop
+                    self._timestamp_response_event.wait()
+                    if self.cancel_requested:
+                        self.conversion_finished.emit("Cancelled", None)
+                        return
                     if not self._timestamp_response:
                         is_timestamp_text = False
                     delattr(self, "_timestamp_response")
+                    self._timestamp_response_event.clear()
 
             # Process subtitle files separately
             if is_subtitle_file or is_timestamp_text:
@@ -2183,6 +2184,7 @@ class ConversionThread(QThread):
     def set_timestamp_response(self, treat_as_subtitle):
         """Set whether to treat timestamp text file as subtitle."""
         self._timestamp_response = treat_as_subtitle
+        self._timestamp_response_event.set()
 
     def _extract_and_add_metadata_tags_to_ffmpeg_cmd(self):
         """Extract metadata tags from text content and add them to ffmpeg command"""