Dymas/abogen
1
0
Fork 0
mirror of https://github.com/denizsafak/abogen.git synced 2026-07-18 21:50:28 +02:00
Code Issues Packages Projects Releases Wiki Activity

feat: Update entity preview button to use new data attributes and improve accessibility

Browse Source
This commit is contained in:
JB
2025-10-12 12:20:15 -07:00
parent 82d780db0d
commit 9ee53fc886
2 changed files with 14 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
abogen/web/static/prepare.js
+13 -6
View File
@@ -1591,7 +1591,7 @@ const initPrepare = (root = document) => {
} }
} }
const previewButton = item.querySelector('[data-role="entity-preview"]'); const previewButton = item.querySelector('[data-entity-preview="true"]');
if (previewButton) { if (previewButton) {
const previewVoice = overrideLookup.get(normalized.toLowerCase())?.voice || baseVoice || ""; const previewVoice = overrideLookup.get(normalized.toLowerCase())?.voice || baseVoice || "";
const previewText = Array.isArray(entity.samples) && entity.samples.length const previewText = Array.isArray(entity.samples) && entity.samples.length
@@ -1606,6 +1606,7 @@ const initPrepare = (root = document) => {
previewButton.dataset.language = languageCode; previewButton.dataset.language = languageCode;
previewButton.dataset.speed = defaultSpeed; previewButton.dataset.speed = defaultSpeed;
previewButton.dataset.useGpu = useGpuDefault; previewButton.dataset.useGpu = useGpuDefault;
previewButton.dataset.previewSource = "entity";
} }
} }
@@ -2077,7 +2078,8 @@ const initPrepare = (root = document) => {
applyEntityPayload(body, { highlightId: highlighted }); applyEntityPayload(body, { highlightId: highlighted });
if (highlightMode === "inline") { if (highlightMode === "inline") {
highlightedOverrideId = highlighted; highlightedOverrideId = highlighted;
activateEntityTab("entities"); const targetPanel = activeEntityPanel || "entities";
activateEntityTab(targetPanel);
} else { } else {
activateEntityTab("manual"); activateEntityTab("manual");
if (manualOverrideResultsList) { if (manualOverrideResultsList) {
@@ -2103,8 +2105,7 @@ const initPrepare = (root = document) => {
}); });
} }
if (entityListNode) { const handleEntityListClick = (event) => {
entityListNode.addEventListener("click", (event) => {
const addTrigger = event.target.closest('[data-role="entity-add-override"]'); const addTrigger = event.target.closest('[data-role="entity-add-override"]');
if (addTrigger) { if (addTrigger) {
event.preventDefault(); event.preventDefault();
@@ -2127,6 +2128,7 @@ const initPrepare = (root = document) => {
} }
inlineOverride.hidden = false; inlineOverride.hidden = false;
inlineOverride.setAttribute("aria-hidden", "false");
const pronInput = inlineOverride.querySelector('[data-role="manual-override-pronunciation"]'); const pronInput = inlineOverride.querySelector('[data-role="manual-override-pronunciation"]');
const voiceSelect = inlineOverride.querySelector('[data-role="manual-override-voice"]'); const voiceSelect = inlineOverride.querySelector('[data-role="manual-override-voice"]');
const previewButton = inlineOverride.querySelector('[data-role="speaker-preview"]'); const previewButton = inlineOverride.querySelector('[data-role="speaker-preview"]');
@@ -2204,11 +2206,16 @@ const initPrepare = (root = document) => {
const inlineOverride = removeTrigger.closest('[data-role="inline-override"]'); const inlineOverride = removeTrigger.closest('[data-role="inline-override"]');
if (inlineOverride) { if (inlineOverride) {
inlineOverride.hidden = true; inlineOverride.hidden = true;
inlineOverride.setAttribute("aria-hidden", "true");
} }
} }
} }
}); };
}
[peopleListNode, entityListNode].forEach((list) => {
if (!list) return;
list.addEventListener("click", handleEntityListClick);
});
if (manualOverrideSearchButton) { if (manualOverrideSearchButton) {
manualOverrideSearchButton.addEventListener("click", () => { manualOverrideSearchButton.addEventListener("click", () => {
abogen/web/templates/partials/new_job_step_entities.html
+1 -1
View File
@@ -404,7 +404,7 @@
</div> </div>
<div class="entity-summary__actions"> <div class="entity-summary__actions">
<span class="badge badge--muted" data-role="entity-count"></span> <span class="badge badge--muted" data-role="entity-count"></span>
<button type="button" class="button button--ghost button--small" data-role="entity-preview" hidden>Preview</button> <button type="button" class="button button--ghost button--small" data-role="speaker-preview" data-entity-preview="true" hidden>Preview</button>
<button type="button" class="button button--ghost button--small" data-role="entity-add-override">Add manual override</button> <button type="button" class="button button--ghost button--small" data-role="entity-add-override">Add manual override</button>
</div> </div>
</header> </header>