Serge ZaigraeffandClaude Opus 4.6
2e2bad8255
- Remove dead code: cache.py, context_managers.py, decorators.py, flask-limiter - Replace AudioSource ABC + FakeFile (5 classes) with 4 plain functions - Replace TempFileManager class with create_temp_file/cleanup_temp_files functions - Simplify RequestLogger from 233 to 65 lines, remove file reading side-effect - Convert HistoryLogger and AudioUtils classes to module-level functions - Remove unused speed_up_audio and audio_speed_factor config - Flatten single-file directories: shared/, api/, storage/, validation/, async_tasks/, logging/ - Merge logging config + request_logger into single infrastructure/log.py - Fix request_logging config key (was request_logger) - Trim CLAUDE.md to high-level only Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
3.0 KiB
3.0 KiB
Development Rules
Living document. Updated after each session.
Hard Rules
Non-negotiable. Violation = stop and fix before continuing.
- Branch freshness: Run
git fetch origin && git log HEAD..origin/dev --onelinebefore work. Rebase if non-empty. - Post-refactor verification: Verify all imports compile (
python -m py_compile <file>) after dependency changes. - Impact assessment: Ask how changes affect the rest of the project before implementation.
- 3+ Iteration Pivot: If a problem requires 3+ iterative fixes, propose a radical architectural simplification.
- Dependency removal audit:
grep -r 'import.*package'all consumers, verify replacement covers every use case before removing.
Git Strategy
- Branch First: Create feature branch from
devfor multi-file or non-trivial changes. Minor features (single-concern, <=3 files) may be committed directly todev. Never work directly onmain. - Base Branch:
devcontains latest stable changes. Always branch fromdev. - Release:
devmerged intomainfor production. Never push directly tomain. - Clean Up: Delete feature branches after merge into
dev.
Coding Constraints
- Use standard library and framework built-ins. No custom algorithms when a one-liner exists.
- No over-engineering, no redundant abstractions. Simplest tool for the job.
- No nested conditional chains. Use lookup dictionaries and early returns.
- Crash on missing configs/dependencies. No default values for critical data (model_path, language).
- Semantic naming and strict type hints mandatory.
- Extract shared utilities only for genuinely reusable operations.
- All code comments and docstrings in Russian (project convention).
Testing
- No formal test suite yet. Verify changes with:
python -m py_compile <file>for syntax/import checks on each modified file.python -c "from app import WhisperServiceAPI"for full import chain validation.- Manual API testing via web UI or curl against running server.
Self-Review (after 3+ file changes)
git diff --stat-- verify only expected files changed.- Full diff review -- incomplete guards, duplicated literals, formatting.
- Grep for old names after renames.
python -m py_compileon every modified.pyfile.
Audio Processing Rules
- FFmpeg and SoX are external dependencies. Always check subprocess return codes.
- Temp files must be created via
create_temp_file()fromapp/infrastructure/storage.py-- never rawtempfile.mktemp. - Audio pipeline order matters: convert to WAV 16kHz -> normalize -> compress/expand -> add silence.
Flask / API Rules
- New endpoints go in
app/routes.pyinside_register_routes(). - All transcription endpoints delegate to
TranscriptionService.transcribe(). - New audio input methods: add a
get_*_file()function insources.pyreturning(temp_path, filename, error). - File validation runs through
FileValidator-- never validate inline in routes. - Configuration values accessed via
self.config.get()with sensible defaults, except critical params which must crash if missing.